Page MenuHomePhabricator
Differential D11246

Fix method visibility for `PhabricatorBitbucketAuthProvider::getProviderConfigurationHelp()`
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 31, 9:30 PM
Unknown Object (File)
Thu, Dec 19, 7:30 PM
Unknown Object (File)
Sun, Dec 15, 10:18 AM
Unknown Object (File)
Thu, Dec 12, 5:17 AM
Unknown Object (File)
Mon, Dec 9, 3:32 AM
Unknown Object (File)
Thu, Dec 5, 12:13 PM
Unknown Object (File)
Thu, Dec 5, 4:04 AM
Unknown Object (File)
Thu, Dec 5, 3:29 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP81972b61d752: Fix method visibility for `PhabricatorBitbucketAuthProvider…
Summary

Ref T6822.

Test Plan

Visual inspection. This method is only called from within PhabricatorOAuthAuthProvider subclasses.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3626
Build 3635: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26992.Jan 6 2015, 10:51 AM
joshuaspence retitled this revision from to Fix method visibility for `PhabricatorBitbucketAuthProvider::getProviderConfigurationHelp()`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:51 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:24 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:48 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:48 PM
Closed by commit rP81972b61d752: Fix method visibility for `PhabricatorBitbucketAuthProvider… (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
2 lines

Diff 26992

View Options

src/applications/auth/provider/PhabricatorBitbucketAuthProvider.php

Loading...
Phabricator · Built by Phacility