Page MenuHomePhabricator
Differential D11237

Fix visibility of various `ArcanistLinter` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 18, 5:10 AM
Unknown Object (File)
Sun, Feb 9, 2:52 PM
Unknown Object (File)
Sat, Feb 8, 12:51 AM
Unknown Object (File)
Sat, Feb 8, 12:51 AM
Unknown Object (File)
Sat, Feb 8, 12:51 AM
Unknown Object (File)
Sat, Feb 8, 12:51 AM
Unknown Object (File)
Wed, Feb 5, 11:44 PM
Unknown Object (File)
Tue, Feb 4, 5:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
rARC828fb41ea729: Fix visibility of various `ArcanistLinter` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the ArcanistExternalLinter and ArcanistLinter subclasses.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3617
Build 3626: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26983.Jan 6 2015, 10:20 AM
joshuaspence retitled this revision from to Fix visibility of various `ArcanistLinter` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:20 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:31 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:51 PM
Closed by commit rARC828fb41ea729: Fix visibility of various `ArcanistLinter` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26983

View Options

src/lint/linter/ArcanistCSSLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistCSharpLinter.php

Loading...
View Options

src/lint/linter/ArcanistChmodLinter.php

Loading...
View Options

src/lint/linter/ArcanistFilenameLinter.php

Loading...
View Options

src/lint/linter/ArcanistFlake8Linter.php

Loading...
View Options

src/lint/linter/ArcanistHLintLinter.php

Loading...
View Options

src/lint/linter/ArcanistPEP8Linter.php

Loading...
View Options

src/lint/linter/ArcanistPhpLinter.php

Loading...
View Options

src/lint/linter/ArcanistPhpcsLinter.php

Loading...
Phabricator · Built by Phacility