Page MenuHomePhabricator
Differential D11231

Add a `PhutilLibraryTestCase` class
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 1:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 12:51 AM
Unknown Object (File)
Sat, Feb 8, 12:50 AM
Unknown Object (File)
Sat, Feb 8, 12:50 AM
Unknown Object (File)
Sat, Feb 8, 12:50 AM
Unknown Object (File)
Sat, Feb 8, 12:50 AM
Unknown Object (File)
Fri, Feb 7, 9:48 AM
Unknown Object (File)
Thu, Jan 30, 7:59 PM
Unknown Object (File)
Thu, Jan 30, 11:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Commits
rPHUe583bc6de6be: Add a `PhutilLibraryTestCase` class
Summary

Some discussion in D11052. Adds a base class for testing phutil libraries.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3606
Build 3614: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26972.Jan 6 2015, 1:37 AM
joshuaspence retitled this revision from to Add a `PhutilLibraryTestCase` class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 1:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 26974.Jan 6 2015, 1:38 AM
joshuaspence added a child revision: D11232: Use `PhutilLibraryTestCase`.
joshuaspence mentioned this in D11232: Use `PhutilLibraryTestCase`.
joshuaspence edited edge metadata.

Remove empty class

joshuaspence added a child revision: D11233: Use `PhutilLibraryTestCase`.Jan 6 2015, 1:43 AM
joshuaspence mentioned this in D11233: Use `PhutilLibraryTestCase`.
joshuaspence added a child revision: D11052: Add a reflection-based unit test for subclasses increasing method visibility.Jan 6 2015, 10:09 AM
joshuaspence mentioned this in D11052: Add a reflection-based unit test for subclasses increasing method visibility.
epriestley accepted this revision.Jan 6 2015, 2:43 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/__tests__/PhutilLibraryTestCase.php
43

Can we new ReflectionClass($this)->getFile() instead? This seems sketchier than that.

This revision is now accepted and ready to land.Jan 6 2015, 2:43 PM
joshuaspence updated this revision to Diff 27038.Jan 6 2015, 8:40 PM
joshuaspence edited edge metadata.

Use ReflectionClass::getFileName()

Closed by commit rPHUe583bc6de6be: Add a `PhutilLibraryTestCase` class (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
__tests__/
36 lines
PhutilLibraryTestCase.php
PhutilInfrastructureTestCase.php
20 lines

Diff 26972

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/__tests__/PhutilInfrastructureTestCase.php

Loading...
View Options

src/__tests__/PhutilLibraryTestCase.php

Loading...
Phabricator · Built by Phacility