Page MenuHomePhabricator
Differential D11231

Add a `PhutilLibraryTestCase` class
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 1:37 AM.
Tags
None
Referenced Files
F15492910: D11231.id27038.diff
Sat, Apr 12, 7:36 PM
F15491886: D11231.id26974.diff
Sat, Apr 12, 8:36 AM
F15488690: D11231.id27039.diff
Fri, Apr 11, 1:34 AM
F15487627: D11231.id27039.diff
Thu, Apr 10, 3:37 PM
F15482775: D11231.id.diff
Wed, Apr 9, 7:59 AM
F15479201: D11231.diff
Tue, Apr 8, 5:30 AM
F15421172: D11231.id26972.diff
Fri, Mar 21, 9:26 PM
F15409041: D11231.id26974.diff
Wed, Mar 19, 3:00 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Group Reviewers
Blessed Reviewers
Commits
rPHUe583bc6de6be: Add a `PhutilLibraryTestCase` class
Summary

Some discussion in D11052. Adds a base class for testing phutil libraries.

Test Plan

arc unit

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26972.Jan 6 2015, 1:37 AM
joshuaspence retitled this revision from to Add a `PhutilLibraryTestCase` class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, btrahan.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 1:37 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 26974.Jan 6 2015, 1:38 AM
joshuaspence added a child revision: D11232: Use `PhutilLibraryTestCase`.
joshuaspence mentioned this in D11232: Use `PhutilLibraryTestCase`.
joshuaspence edited edge metadata.

Remove empty class

joshuaspence added a child revision: D11233: Use `PhutilLibraryTestCase`.Jan 6 2015, 1:43 AM
joshuaspence mentioned this in D11233: Use `PhutilLibraryTestCase`.
joshuaspence added a child revision: D11052: Add a reflection-based unit test for subclasses increasing method visibility.Jan 6 2015, 10:09 AM
joshuaspence mentioned this in D11052: Add a reflection-based unit test for subclasses increasing method visibility.
epriestley accepted this revision.Jan 6 2015, 2:43 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/__tests__/PhutilLibraryTestCase.php
46

Can we new ReflectionClass($this)->getFile() instead? This seems sketchier than that.

This revision is now accepted and ready to land.Jan 6 2015, 2:43 PM
joshuaspence updated this revision to Diff 27038.Jan 6 2015, 8:40 PM
joshuaspence edited edge metadata.

Use ReflectionClass::getFileName()

Closed by commit rPHUe583bc6de6be: Add a `PhutilLibraryTestCase` class (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
__tests__/
PhutilLibraryTestCase.php
PhutilInfrastructureTestCase.php
23 lines

Diff 27039

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/__tests__/PhutilInfrastructureTestCase.php

Loading...
View Options

src/__tests__/PhutilLibraryTestCase.php

Loading...
Phabricator · Built by Phacility