Page MenuHomePhabricator
Differential D11191

Rename the `PhabricatorAuthFactorTOTP` class for consistency
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 3:29 AM.
Tags
None
Referenced Files
F13273306: D11191.diff
Fri, May 31, 1:47 AM
F13261611: D11191.diff
Mon, May 27, 1:15 AM
F13249224: D11191.id26859.diff
Fri, May 24, 7:49 AM
F13232267: D11191.diff
Tue, May 21, 1:09 AM
F13225029: D11191.diff
Sun, May 19, 12:56 PM
F13213377: D11191.diff
Fri, May 17, 7:41 AM
Unknown Object (File)
Tue, May 7, 2:48 AM
Unknown Object (File)
Fri, May 3, 4:02 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rPf2e87aad89e9: Rename the `PhabricatorAuthFactorTOTP` class for consistency
Summary

Ref T5655.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3541
Build 3549: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26859.Jan 4 2015, 3:29 AM
joshuaspence retitled this revision from to Rename the `PhabricatorAuthFactorTOTP` class for consistency.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 3:29 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 4 2015, 4:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 4:32 PM
joshuaspence added a comment.Jan 4 2015, 7:21 PM

I haven't checked whether any migrations are needed for this change. I'll see if I can do that as well.

Closed by commit rPf2e87aad89e9: Rename the `PhabricatorAuthFactorTOTP` class for consistency (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 11:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
8 lines
applications/
auth/
factor/
PhabricatorTOTPAuthFactor.php
PhabricatorAuthFactorTOTP.php
2 lines
__tests__/
PhabricatorTOTPAuthFactorTestCase.php
PhabricatorAuthFactorTOTPTestCase.php
4 lines

Diff 26859

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/auth/factor/PhabricatorAuthFactorTOTP.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/factor/__tests__/PhabricatorAuthFactorTOTPTestCase.php

Loading...
View Options

src/applications/auth/factor/__tests__/PhabricatorTOTPAuthFactorTestCase.php

Loading...
Phabricator · Built by Phacility