Don't write inverse edges for `DifferentialRevisionHasReviewerEdgeType`
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 11:07 PM.

Details

Reviewers

Krenair
epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP2dea11047aa8: Don't write inverse edges for `DifferentialRevisionHasReviewerEdgeType`

Summary

The default behavior was inadvertedly changed in D11074. This restores the original behavior.

Test Plan

Added a project reviewer to a diff, saw no inverse transaction recorded.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3529
Build 3537: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26845.Jan 3 2015, 11:07 PM

joshuaspence retitled this revision from to Don't write inverse edges for `DifferentialRevisionHasReviewerEdgeType`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, Krenair.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 3 2015, 11:07 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 3 2015, 11:07 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 3 2015, 11:07 PM

Closed by commit rP2dea11047aa8: Don't write inverse edges for `DifferentialRevisionHasReviewerEdgeType` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 3 2015, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

edge/

DifferentialRevisionHasReviewerEdgeType.php

4 lines

Diff 26845

View Options

src/applications/differential/edge/DifferentialRevisionHasReviewerEdgeType.php

Don't write inverse edges for `DifferentialRevisionHasReviewerEdgeType`ClosedPublicActions