Page MenuHomePhabricator
Differential D11172

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 4:53 AM.
Tags
None
Referenced Files
F15410732: D11172.diff
Wed, Mar 19, 8:18 AM
F15338911: D11172.id26822.diff
Sun, Mar 9, 1:25 PM
F15284119: D11172.diff
Tue, Mar 4, 9:14 AM
Unknown Object (File)
Sat, Feb 22, 5:34 AM
Unknown Object (File)
Tue, Feb 18, 3:18 PM
Unknown Object (File)
Feb 8 2025, 12:43 AM
Unknown Object (File)
Feb 8 2025, 12:43 AM
Unknown Object (File)
Feb 8 2025, 12:43 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
rARCf5db41917be6: Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
Summary

This is a bit magical and is maybe a terrible idea, but it seems okayish.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26822.Jan 3 2015, 4:53 AM
joshuaspence retitled this revision from to Reduce boilerplate code in `ArcanistLinterTestCase` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptJan 3 2015, 4:53 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 3 2015, 12:33 PM
epriestley edited edge metadata.

Seems fine to me, I can't come up with a way that this would ever do the wrong thing.

This revision is now accepted and ready to land.Jan 3 2015, 12:33 PM
Closed by commit rARCf5db41917be6: Reduce boilerplate code in `ArcanistLinterTestCase` subclasses (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 7:44 AM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D10738: Added RuboCop linter.Jan 19 2015, 7:46 AM

Revision Contents
Changeset List

Diff 26865

View Options

src/lint/linter/__tests__/ArcanistCSSLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCoffeeLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCommitLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCppcheckLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistFlake8LinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistHLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJSONLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJSONLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistJscsLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLesscLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPEP8LinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPhpLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPhpcsLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPyFlakesLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistPyLintLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistRubyLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

Loading...
View Options

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

Loading...
Phabricator · Built by Phacility