Page MenuHomePhabricator
Differential D11166

Rename `PhabricatorPolicyRule` subclasses for consistency
ClosedPublic
Actions

Authored by joshuaspence on Jan 3 2015, 1:06 AM.
Tags
None
Referenced Files
F15475122: D11166.diff
Sun, Apr 6, 3:59 PM
F15474278: D11166.diff
Sun, Apr 6, 6:56 AM
F15423434: D11166.id26812.diff
Sat, Mar 22, 3:26 PM
F15423433: D11166.id26813.diff
Sat, Mar 22, 3:26 PM
F15367643: D11166.diff
Tue, Mar 11, 8:15 PM
F15366318: D11166.id.diff
Tue, Mar 11, 2:57 PM
F15352148: D11166.id.diff
Mon, Mar 10, 4:13 PM
F15341149: D11166.diff
Sun, Mar 9, 6:51 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored
T5655: Standardize naming conventions
Commits
Restricted Diffusion Commit
rPb3e196b69400: Rename `PhabricatorPolicyRule` subclasses for consistency
Summary

Ref T5655. Fixes T6849. This is another take on D11131, which was missing the DB migration and was reverted in rP7c4de0f6be77ddaea593e1f41ae27211ec179a55.

Test Plan

Ran ./bin/storage upgrade and verified that the classes were renamed in the phabricator_policy.policy table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26812.Jan 3 2015, 1:06 AM
joshuaspence retitled this revision from to Rename `PhabricatorPolicyRule` subclasses for consistency.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added tasks: T5655: Standardize naming conventions, T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 3 2015, 1:06 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 26813.Jan 3 2015, 1:19 AM
joshuaspence edited edge metadata.

Fixed migration

joshuaspence updated this object.Jan 3 2015, 1:20 AM
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Jan 3 2015, 12:22 PM
epriestley edited edge metadata.

This applied cleanly locally and looks good to me.

resources/sql/autopatches/20150102.policyname.php
20

(This comment is copy/paste from elsewhere maybe?)

This revision is now accepted and ready to land.Jan 3 2015, 12:23 PM
Closed by commit rPb3e196b69400: Rename `PhabricatorPolicyRule` subclasses for consistency (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 3 2015, 12:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
38 lines
src/
20 lines
applications/
policy/
__tests__/
6 lines
rule/
PhabricatorAdministratorsPolicyRule.php
PhabricatorPolicyRuleAdministrators.php
3 lines
PhabricatorLegalpadSignaturePolicyRule.php
PhabricatorPolicyRuleLegalpadSignature.php
2 lines
PhabricatorLunarPhasePolicyRule.php
PhabricatorPolicyRuleLunarPhase.php
3 lines
PhabricatorProjectsPolicyRule.php
PhabricatorPolicyRuleProjects.php
3 lines
PhabricatorUsersPolicyRule.php
PhabricatorPolicyRuleUsers.php
3 lines

Diff 26828

View Options

resources/sql/autopatches/20150102.policyname.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php

Loading...
View Options

src/applications/policy/rule/PhabricatorAdministratorsPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorLegalpadSignaturePolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorLunarPhasePolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleAdministrators.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleLunarPhase.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleProjects.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleUsers.php

Loading...
View Options

src/applications/policy/rule/PhabricatorProjectsPolicyRule.php

Loading...
View Options

src/applications/policy/rule/PhabricatorUsersPolicyRule.php

Loading...
Phabricator · Built by Phacility