Page MenuHomePhabricator

Fix some edge strings; particularly revision editing
ClosedPublic

Authored by epriestley on Jan 2 2015, 9:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 11:30 AM
Unknown Object (File)
Thu, Nov 28, 5:40 AM
Unknown Object (File)
Wed, Nov 27, 8:07 PM
Unknown Object (File)
Wed, Nov 27, 2:36 AM
Unknown Object (File)
Sun, Nov 24, 10:06 PM
Unknown Object (File)
Oct 30 2024, 6:37 AM
Unknown Object (File)
Oct 18 2024, 3:22 PM
Unknown Object (File)
Oct 18 2024, 12:39 PM
Subscribers

Details

Summary

These didn't get translated quite right:

  • We need to use $total_count because some languages have different words for 1, 2-3, and 4+ things (for example). So the strings might translate as:
    • alincoln added a reviewer-one ...
    • alincoln added reviewers-few ...
    • alincoln added reviewers-many ...
  • That is, while English has only "reviewer" and "reviewers", other languages have more plural forms, and "reviewer", "reviewers-few" and "reviewers-many" may be completely different words.
  • In English, because we know we always have 2+ in this branch and the only special word is for 1, we can just drop this.
  • Anyway, the %4$s stuff is counting assuming that $total_count is included in the string, so these were a off by one.
  • See also D11160.

There a probably a couple more of these, but they should be easy enough to hunt down as they crop up.

Test Plan

Saw nice strings instead of empty strings, or invalid strings (after D11160).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix some edge strings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 9:46 PM
epriestley retitled this revision from Fix some edge strings to Fix some edge strings; particularly revision editing.Jan 2 2015, 9:48 PM
epriestley edited edge metadata.
This revision was automatically updated to reflect the committed changes.