Page MenuHomePhabricator

When a translated string is bogus, partially recover
ClosedPublic

Authored by epriestley on Jan 2 2015, 9:35 PM.
Tags
None
Referenced Files
F15465508: D11160.id26780.diff
Wed, Apr 2, 7:43 PM
F15440111: D11160.diff
Wed, Mar 26, 11:00 AM
F15424426: D11160.diff
Sat, Mar 22, 10:20 PM
F15412131: D11160.id26786.diff
Wed, Mar 19, 11:25 AM
F15411982: D11160.id26785.diff
Wed, Mar 19, 10:38 AM
F15409613: D11160.id26780.diff
Wed, Mar 19, 4:46 AM
F15400796: D11160.diff
Mon, Mar 17, 2:02 PM
F15357580: D11160.id26785.diff
Tue, Mar 11, 6:47 AM
Subscribers

Details

Summary

Hit one of these; this makes it easier to figure out which string is problematic.

Test Plan

Saw UI render a string which I could more easily hunt down.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When a translated string is bogus, partially recover.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 9:38 PM
src/internationalization/PhutilTranslator.php
64

Isn't this basically what idx does?

src/internationalization/PhutilTranslator.php
64

Oh, sorry, this was dirty nonsense in my working copy. Thanks for catching that.

This was an alternate version of rP1984539: basically, if you have an extracted translation array like this:

array(

'apple' => null,

);

...that is, you haven't written any translations yet, then idx() will select the key and you'll get null.

An alternate version of this would be:

$translation = coalesce(idx($this->translations, $text), $text);

...but rP1984539 was a cleaner fix.

epriestley edited edge metadata.
  • Cleanup leftovers.