When a translated string is bogus, partially recover
ClosedPublic
Actions

Authored by epriestley on Jan 2 2015, 9:35 PM.

Details

Reviewers

joshuaspence
btrahan

Commits

Summary

Hit one of these; this makes it easier to figure out which string is problematic.

Test Plan

Saw UI render a string which I could more easily hunt down.

Repository

rPHU libphutil

Branch

i18n2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3498
Build 3506: [Placeholder Plan] Wait for 30 Seconds

epriestley retitled this revision from to When a translated string is bogus, partially recover.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 9:38 PM

src/internationalization/PhutilTranslator.php
64	Isn't this basically what `idx` does?

src/internationalization/PhutilTranslator.php
64	Oh, sorry, this was dirty nonsense in my working copy. Thanks for catching that. This was an alternate version of rP1984539: basically, if you have an extracted translation array like this: array( 'apple' => null, ); ...that is, you haven't written any translations yet, then `idx()` will select the key and you'll get `null`. An alternate version of this would be: $translation = coalesce(idx($this->translations, $text), $text); ...but rP1984539 was a cleaner fix.