Page MenuHomePhabricator
Differential D11113

Modernize Pholio edges
ClosedPublic
Actions

Authored by joshuaspence on Jan 1 2015, 4:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 12:07 AM
Unknown Object (File)
Fri, Dec 27, 6:53 PM
Unknown Object (File)
Tue, Dec 24, 7:39 AM
Unknown Object (File)
Sat, Dec 14, 11:49 PM
Unknown Object (File)
Thu, Dec 12, 2:43 PM
Unknown Object (File)
Dec 3 2024, 5:19 AM
Unknown Object (File)
Dec 2 2024, 3:28 AM
Unknown Object (File)
Nov 28 2024, 7:23 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPa6acedef0b24: Modernize Pholio edges
Summary

Modernize Pholio edges to subclass PhabricatorEdgeType. Largely based on D11045.

Test Plan

Attached a mock to a task, observed the expected comment in the transaction view (both ways).

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3442
Build 3449: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26688.Jan 1 2015, 4:46 AM
joshuaspence retitled this revision from to Modernize Pholio edges.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 1 2015, 4:46 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence updated this object.Jan 1 2015, 5:44 AM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited the test plan for this revision. (Show Details)Jan 1 2015, 5:49 AM
joshuaspence updated this revision to Diff 26693.Jan 1 2015, 6:15 AM

Rebase onto D11111

Herald added a subscriber: Korvin. · View Herald TranscriptJan 1 2015, 6:15 AM
joshuaspence added a parent revision: D11111: Migrate Project edges to subclass `PhabricatorEdgeType`.Jan 1 2015, 12:33 PM
epriestley accepted this revision.Jan 1 2015, 2:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 1 2015, 2:36 PM
Closed by commit rPa6acedef0b24: Modernize Pholio edges (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 1 2015, 11:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
4 lines
applications/
maniphest/
controller/
4 lines
edge/
102 lines
pholio/
controller/
2 lines
edge/
102 lines
search/
controller/
4 lines
infrastructure/
edges/
constants/
22 lines
internationalization/
translation/
24 lines

Diff 26693

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/edge/ManiphestTaskHasMockEdgeType.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/pholio/edge/PholioMockHasTaskEdgeType.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
View Options

src/infrastructure/edges/constants/PhabricatorEdgeConfig.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility