Differential D11087

Fix two linter issues
ClosedPublic
Actions

Authored by epriestley on Dec 30 2014, 3:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 18, 10:59 PM

	Unknown Object (File)
	Sun, Nov 17, 2:30 PM

	Unknown Object (File)
	Tue, Oct 29, 9:12 AM

	Unknown Object (File)
	Tue, Oct 29, 12:43 AM

	Unknown Object (File)
	Oct 20 2024, 5:50 PM

	Unknown Object (File)
	Oct 17 2024, 7:25 AM

	Unknown Object (File)
	Sep 15 2024, 2:09 AM

	Unknown Object (File)
	Sep 15 2024, 2:08 AM

Subscribers

Details

Reviewers

joshuaspence
btrahan

Commits

rARCa3c3d23dd770: Fix two linter issues

Summary

The "exclude static variable access" branch in XHPAST incorrectly excluded all variables in a function or method which used any static access (we were selecting the wrong root node for exclusion).
The "PHPLinter" regexp did not work with 5.4.30. Make it more permissive in what it parses.

Test Plan

Added a failing unit test for the variable case and made it pass.
PHPLinter tests now pass under 5.4.30

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 26612.Dec 30 2014, 3:00 PM

epriestley retitled this revision from to Fix two linter issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptDec 30 2014, 3:00 PM

epriestley mentioned this in D11050: make repo callsigns optional.Dec 30 2014, 3:21 PM

Yay test coverage

This revision is now accepted and ready to land.Dec 30 2014, 6:01 PM

Closed by commit rARCa3c3d23dd770: Fix two linter issues (authored by epriestley, committed by epriestley). · Explain WhyDec 30 2014, 6:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhpLinter.php

4 lines

ArcanistXHPASTLinter.php

10 lines

__tests__/

xhpast/

naming-conventions.lint-test

8 lines

Diff 26621

src/lint/linter/ArcanistPhpLinter.php

Loading...

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/naming-conventions.lint-test

Loading...