Page MenuHomePhabricator

Fix `str` being defined as a global variable
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 10:27 AM.
Tags
None
Referenced Files
F13975709: D11068.diff
Fri, Oct 18, 11:18 AM
F13974597: D11068.diff
Fri, Oct 18, 6:20 AM
F13971724: D11068.id.diff
Thu, Oct 17, 2:58 PM
F13971374: D11068.id26561.diff
Thu, Oct 17, 1:02 PM
Unknown Object (File)
Fri, Oct 11, 9:05 AM
Unknown Object (File)
Oct 10 2024, 11:39 AM
Unknown Object (File)
Oct 1 2024, 2:56 AM
Unknown Object (File)
Sep 24 2024, 12:24 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP6b17a5a6ca49: Fix `str` being defined as a global variable
Summary

This variable should be local, not global. This silences a few JSHint warnings.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix `str` being defined as a global variable.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 10:57 AM
This revision was automatically updated to reflect the committed changes.