Paths

Table of Contentst

Differential D11068

Fix `str` being defined as a global variable
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 10:27 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP6b17a5a6ca49: Fix `str` being defined as a global variable

Summary

This variable should be local, not global. This silences a few JSHint warnings.

Test Plan

arc lint

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3363
Build 3370: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26561.Dec 30 2014, 10:27 AM

joshuaspence retitled this revision from to Fix `str` being defined as a global variable.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 10:27 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Dec 30 2014, 10:57 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Dec 30 2014, 10:57 AM

Closed by commit rP6b17a5a6ca49: Fix `str` being defined as a global variable (authored by joshuaspence, committed by epriestley). · Explain WhyDec 30 2014, 10:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

application/

maniphest/

behavior-line-chart.js

2 lines

Diff 26561

View Options

resources/celerity/map.php