Page MenuHomePhabricator

Maniphest - remove references to deprecated transaction type TYPE_PROJECTS from code
ClosedPublic

Authored by btrahan on Dec 18 2014, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 8:40 PM
Unknown Object (File)
Fri, Dec 6, 6:11 AM
Unknown Object (File)
Sat, Nov 30, 4:00 AM
Unknown Object (File)
Sun, Nov 24, 8:47 PM
Unknown Object (File)
Thu, Nov 21, 4:21 AM
Unknown Object (File)
Nov 16 2024, 9:23 PM
Unknown Object (File)
Nov 5 2024, 3:02 PM
Unknown Object (File)
Oct 19 2024, 9:28 PM
Subscribers

Details

Summary

...except the transaction class itself, which still needs some knowledge of these transactions for older installs.

Ref T5245. T5604 and T5245 are now in a similar place -- there's an unknown set of bugs introduced from my changes and there's still old display code lying around with some old transactions in the database. I'll stomp out the bugs if / when they surface and data migration is up next.

This revision also adds a "TransactionPreviewString" method to the edge objects so that we can have a prettier "Bob edited associated projects." preview of this transaction.

Test Plan

added a project from task detail and saw correct preview throughout process with correct project added. bulk removed a project from some tasks. added a project from the edit details pane.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Maniphest - remove references to deprecated transaction type TYPE_PROJECTS from code.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 18 2014, 10:14 PM
This revision was automatically updated to reflect the committed changes.