Page MenuHomePhabricator

Allow binary files to be uploaded via arcanist under windows
AbandonedPublic

Authored by richardvanvelzen on Dec 15 2014, 7:22 PM.
Tags
None
Referenced Files
F13239006: D10994.id26399.diff
Tue, May 21, 11:22 PM
F13234260: D10994.diff
Tue, May 21, 3:15 AM
F13211834: D10994.diff
Fri, May 17, 6:08 AM
F13195505: D10994.diff
Sun, May 12, 10:26 PM
F13178255: D10994.diff
Wed, May 8, 8:18 PM
Unknown Object (File)
Apr 25 2024, 1:47 AM
Unknown Object (File)
Feb 25 2024, 1:45 AM
Unknown Object (File)
Feb 12 2024, 6:51 AM
Subscribers

Details

Summary

Fixes T6112. escapeshellarg on Windows removes %-signs, which makes the command string for the bulk hg cat fail.

Test Plan

Ran arc diff on some repository to which I added binary files. Asserted that the files were correctly uploaded and viewable in Differential.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 3264
Build 3270: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestGitStateParsing
0 mstestHgStateParsing
0 mstestSVNFileEscapes
0 mstestSvnStateParsing