Page MenuHomePhabricator

Transactions - make sure to do fancy remarkup stuff on edit too
ClosedPublic

Authored by btrahan on Dec 2 2014, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 3:29 AM
Unknown Object (File)
Thu, Dec 19, 1:18 PM
Unknown Object (File)
Thu, Dec 19, 1:18 PM
Unknown Object (File)
Thu, Dec 19, 1:18 PM
Unknown Object (File)
Thu, Dec 19, 1:18 PM
Unknown Object (File)
Thu, Dec 19, 10:51 AM
Unknown Object (File)
Sun, Dec 8, 3:47 AM
Unknown Object (File)
Sat, Dec 7, 6:08 AM
Subscribers

Details

Summary

Fixes T6648. We do some automagical hotness based on the text you enter in remarkup textareas - e.g. adding projects or mentioning other objects. Refine the code here so that even when just editing a comment we build these transactions and apply them.

Test Plan

edited a comment and noted new mentions and projects showed up appropriately...!

Diff Detail

Repository
rP Phabricator
Branch
T6648
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3168
Build 3174: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Transactions - make sure to do fancy remarkup stuff on edit too.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
1129–1134

Maybe just do something like filter out the object which === $xaction explicitly, in case expandSupportTransactions() ever messes around with transaction order, but this seems generally reasonable.

This revision is now accepted and ready to land.Dec 3 2014, 12:34 AM
btrahan edited edge metadata.
  • use === to lower brittleness
This revision was automatically updated to reflect the committed changes.