Fixes T6648. We do some automagical hotness based on the text you enter in remarkup textareas - e.g. adding projects or mentioning other objects. Refine the code here so that even when just editing a comment we build these transactions and apply them.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6648: Mention transaction not created after editing comment
- Commits
- Restricted Diffusion Commit
rP798be00fc3c7: Transactions - make sure to do fancy remarkup stuff on edit too
edited a comment and noted new mentions and projects showed up appropriately...!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6648
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3168 Build 3174: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php | ||
---|---|---|
1129–1134 | Maybe just do something like filter out the object which === $xaction explicitly, in case expandSupportTransactions() ever messes around with transaction order, but this seems generally reasonable. |