Page MenuHomePhabricator
Create Task
Maniphest T6648

Mention transaction not created after editing comment
Closed, ResolvedPublic
Actions

Description

Steps to reproduce.

  1. Write Comment mentioning T123
  2. Edit Comment to mention T124 instead
  3. Original mention still noted on T123, T124 has nothing.

Revisions and Commits

rP Phabricator
D10922rP798be00fc3c7 Transactions - make sure to do fancy remarkup stuff on edit too

Event Timeline

aik099 created this task.Nov 26 2014, 9:04 AM
aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Audit.
aik099 updated the task description. (Show Details)
aik099 added a subscriber: aik099.
chad renamed this task from Mention not created after editing Audit comment to Mention transaction not created after editing comment.Nov 26 2014, 4:37 PM
chad updated the task description. (Show Details)
chad edited projects, added Transactions, Support Impact; removed Audit.
chad added a subscriber: btrahan.
chad added subscribers: chad, epriestley.
chad triaged this task as Normal priority.Nov 26 2014, 10:04 PM
btrahan added a comment.Dec 2 2014, 10:29 PM

Is the desired behavior that

  • original mention of T123 stays and mention of T124 is added

OR

  • original mention of T123 is updated to T124

?

The former should be pretty easy. The latter should be pretty tricky; we currently don't store "what comment, description, etc" mentioned the object such that editing one does not mean it wasn't mentioned in another.

epriestley added a comment.Dec 2 2014, 10:30 PM

I think adding is desirable. We never rewrite history anywhere else.

btrahan claimed this task.Dec 2 2014, 10:31 PM
btrahan added a revision: D10922: Transactions - make sure to do fancy remarkup stuff on edit too.Dec 2 2014, 11:12 PM
btrahan closed this task as Resolved.Dec 3 2014, 1:03 AM
btrahan added a commit: rP798be00fc3c7: Transactions - make sure to do fancy remarkup stuff on edit too.

Closed by commit rP798be00fc3c7.

Phabricator · Built by Phacility