Page MenuHomePhabricator
Differential D10922

Transactions - make sure to do fancy remarkup stuff on edit too
ClosedPublic
Actions

Authored by btrahan on Dec 2 2014, 11:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 3:47 AM
Unknown Object (File)
Sat, Dec 7, 6:08 AM
Unknown Object (File)
Tue, Nov 26, 9:04 PM
Unknown Object (File)
Fri, Nov 22, 3:52 AM
Unknown Object (File)
Nov 17 2024, 10:09 PM
Unknown Object (File)
Nov 14 2024, 10:40 AM
Unknown Object (File)
Nov 11 2024, 7:31 AM
Unknown Object (File)
Nov 10 2024, 9:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6648: Mention transaction not created after editing comment
Commits
Restricted Diffusion Commit
rP798be00fc3c7: Transactions - make sure to do fancy remarkup stuff on edit too
Summary

Fixes T6648. We do some automagical hotness based on the text you enter in remarkup textareas - e.g. adding projects or mentioning other objects. Refine the code here so that even when just editing a comment we build these transactions and apply them.

Test Plan

edited a comment and noted new mentions and projects showed up appropriately...!

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 26235.Dec 2 2014, 11:12 PM
btrahan added a task: T6648: Mention transaction not created after editing comment.
btrahan retitled this revision from to Transactions - make sure to do fancy remarkup stuff on edit too.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptDec 2 2014, 11:12 PM
epriestley accepted this revision.Dec 3 2014, 12:34 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
1129–1134

Maybe just do something like filter out the object which === $xaction explicitly, in case expandSupportTransactions() ever messes around with transaction order, but this seems generally reasonable.

This revision is now accepted and ready to land.Dec 3 2014, 12:34 AM
btrahan updated this revision to Diff 26236.Dec 3 2014, 1:02 AM
btrahan edited edge metadata.
  • use === to lower brittleness
Closed by commit rP798be00fc3c7: Transactions - make sure to do fancy remarkup stuff on edit too (authored by btrahan, committed by btrahan). · Explain WhyDec 3 2014, 1:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26237

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility