Page MenuHomePhabricator
Differential D10752

Fixed MediaWiki logo in login sprite sheets.
ClosedPublic
Actions

Authored by 20after4 on Oct 29 2014, 3:52 AM.
Tags
Referenced Files
Unknown Object (File)
Thu, Dec 12, 5:03 AM
Unknown Object (File)
Thu, Dec 12, 4:08 AM
Unknown Object (File)
Thu, Dec 12, 2:21 AM
Unknown Object (File)
Sat, Dec 7, 1:42 PM
Unknown Object (File)
Thu, Dec 5, 11:28 PM
Unknown Object (File)
Tue, Dec 3, 1:17 PM
Unknown Object (File)
Sat, Nov 30, 6:32 AM
Unknown Object (File)
Thu, Nov 28, 4:29 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
qgil
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPbf66c90852ba: Fixed MediaWiki logo in login sprite sheets.
Summary

I've been advised that that the MediaWiki flower needs to
appear with the square brackets for proper MediaWiki trademark
presentation.

See https://phabricator.wikimedia.org/T543 for relevant discussion.

Test Plan

view login page with MediaWiki oauth plugin enabled,
see that the logo includes square brackets around the flower

Diff Detail

Repository
rP Phabricator
Branch
upstreammaster
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2902
Build 2906: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

20after4 updated this revision to Diff 25807.Oct 29 2014, 3:52 AM
20after4 retitled this revision from to Fixed MediaWiki logo in login sprite sheets..
20after4 added reviewers: epriestley, qgil.
20after4 edited the test plan for this revision. (Show Details)
20after4 updated this object.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 29 2014, 3:52 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
20after4 added a comment.Oct 29 2014, 3:53 AM

see also D9202 and D9203

Harbormaster completed remote builds in B2895: Diff 25807.Oct 29 2014, 3:53 AM
epriestley added a reviewer: chad.Oct 29 2014, 3:55 AM
chad edited edge metadata.Oct 29 2014, 3:57 AM

These are generated files, you'll have to add the individual files to the sprite folder and run scripts/celerity/generate_sprites.php

20after4 edited edge metadata.Oct 29 2014, 3:58 AM
20after4 added projects: Auth, Wikimedia.

@chad I'm sorry I didn't realize they were generated...

chad added a comment.Oct 29 2014, 3:59 AM

No worries!

20after4 updated this revision to Diff 25808.Oct 29 2014, 4:13 AM

Properly re-generate spritesheet from source images.

Harbormaster completed remote builds in B2896: Diff 25808.Oct 29 2014, 4:14 AM
chad added a comment.Oct 29 2014, 4:26 AM

I think you also need to run bin/celerity map with new images.

20after4 updated this revision to Diff 25816.Oct 29 2014, 8:08 PM
  • update celerity map
Harbormaster completed remote builds in B2902: Diff 25816.Oct 29 2014, 8:09 PM
chad accepted this revision.Oct 29 2014, 8:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 29 2014, 8:23 PM
Closed by commit rPbf66c90852ba: Fixed MediaWiki logo in login sprite sheets. (authored by chad, committed by chad). · Explain WhyOct 29 2014, 10:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
60 lines
sprite/
login_1x/
login_2x/
manifest/
2 lines
webroot/
rsrc/
image/

Diff 25816

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/login_1x/MediaWiki.png

Loading...
View Options

resources/sprite/login_2x/MediaWiki.png

Loading...
View Options

resources/sprite/manifest/login.json

Loading...
View Options

webroot/rsrc/image/sprite-login-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-login.png

Loading...
Phabricator · Built by Phacility