Page MenuHomePhabricator

Adjust payment workflows to deal with merchants and configurable providers in Phortune
ClosedPublic

Authored by epriestley on Oct 7 2014, 8:08 PM.
Tags
None
Referenced Files
F15666940: D10652.diff
Sun, May 25, 9:19 AM
Unknown Object (File)
Wed, May 21, 2:59 AM
Unknown Object (File)
Mon, May 19, 2:15 AM
Unknown Object (File)
Sun, Apr 27, 1:55 AM
Unknown Object (File)
Apr 24 2025, 1:41 AM
Unknown Object (File)
Apr 23 2025, 3:10 PM
Unknown Object (File)
Apr 22 2025, 1:58 AM
Unknown Object (File)
Apr 21 2025, 1:39 AM
Subscribers

Details

Summary

Ref T2787. Builds on D10649 by rebining existing objects (carts, charges, etc) to merchantPHIDs and providerPHIDs instead of an implicit global merchant and weird global artifacts (providerType / providerKey).

Basically:

  • When you create something that users can pay for, you specify a merchant to control where the payment goes.
  • Accounts are install-wide, but payment methods are bound to merchants. This seems to do a reasonable job of balancing usability and technical concerns.
  • Replace a bunch of weird links between objects with standard PHIDs.
  • Improve "add payment method" flow.
Test Plan

Went through the Fund flow with Stripe and WePay, funding an initiative.

Diff Detail

Repository
rP Phabricator
Branch
fund13
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2766
Build 2770: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Adjust payment workflows to deal with merchants and configurable providers in Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 7 2014, 9:40 PM
This revision was automatically updated to reflect the committed changes.