Differential D10649

Make payment providers a configurable property of Merchants in Phortune
ClosedPublic
Actions

Authored by epriestley on Oct 7 2014, 5:52 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2787: Build Phortune into a real accounts/billing application

Commits

Restricted Diffusion Commit
rP9aa5a8cb7b5f: Make payment providers a configurable property of Merchants in Phortune

Summary

Ref T2787. Instead of making providers global configuration, make them a thing on merchants with web configuration.

Payment methods and some of the pyament workflow needs to be retooled a bit after this, but this seemed like a reasonable cutoff point for this diff.

Test Plan

See screenshots.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25576.Oct 7 2014, 5:52 PM

epriestley retitled this revision from to Make payment providers a configurable property of Merchants in Phortune.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2787: Build Phortune into a real accounts/billing application.

Herald added a subscriber: epriestley. · View Herald TranscriptOct 7 2014, 5:52 PM

Specifically, the rename at issue is one that changes only the case of the filename (from "Paypal" to "PayPal").

Harbormaster completed remote builds in B2763: Diff 25576.Oct 7 2014, 5:53 PM

Screen_Shot_2014-10-07_at_10.41.07_AM.png (1×1 px, 171 KB)

Screen_Shot_2014-10-07_at_10.41.01_AM.png (1×1 px, 180 KB)

Screen_Shot_2014-10-07_at_10.40.52_AM.png (1×1 px, 188 KB)

Screen_Shot_2014-10-07_at_10.40.56_AM.png (1×1 px, 189 KB)

Screen_Shot_2014-10-07_at_10.40.58_AM.png (1×1 px, 142 KB)

Screen_Shot_2014-10-07_at_10.41.04_AM.png (1×1 px, 168 KB)

epriestley mentioned this in D10652: Adjust payment workflows to deal with merchants and configurable providers in Phortune.Oct 7 2014, 8:08 PM

btrahan accepted this revision.Oct 7 2014, 9:37 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2014, 9:37 PM

Closed by commit rP9aa5a8cb7b5f: Make payment providers a configurable property of Merchants in Phortune (authored by epriestley, committed by epriestley).Oct 7 2014, 9:41 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11168: Remove unused Phortune exceptions.Jan 3 2015, 3:13 AM

joshuaspence mentioned this in rPcdf11c9fd170: Remove unused Phortune exceptions.Jan 3 2015, 12:52 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20141007.phortuneprovider.sql

12 lines

20141007.phortuneproviderx.sql

19 lines

src/

__phutil_library_map__.php

31 lines

applications/

phortune/

application/

PhabricatorPhortuneApplication.php

7 lines

controller/

PhortuneMerchantViewController.php

58 lines

	PhortuneProviderActionController.php
	PhortuneProviderController.php

26 lines

PhortuneProviderController.php

PhortuneProviderEditController.php

292 lines

editor/

PhortunePaymentProviderConfigEditor.php

81 lines

option/

PhabricatorPhortuneConfigOptions.php

phid/

PhortunePaymentProviderPHIDType.php

38 lines

provider/

PhortuneBalancedPaymentProvider.php

129 lines

	PhortunePayPalPaymentProvider.php
	PhortunePaypalPaymentProvider.php

166 lines

PhortunePaymentProvider.php

166 lines

PhortunePaypalPaymentProvider.php

PhortuneStripePaymentProvider.php

105 lines

PhortuneTestPaymentProvider.php

56 lines

PhortuneWePayPaymentProvider.php

157 lines

__tests__/

PhortunePaymentProviderTestCase.php

PhortuneTestExtraPaymentProvider.php

query/

PhortunePaymentProviderConfigQuery.php

95 lines

PhortunePaymentProviderConfigTransactionQuery.php

10 lines

storage/

PhortunePaymentMethod.php

25 lines

PhortunePaymentProviderConfig.php

96 lines

PhortunePaymentProviderConfigTransaction.php

46 lines

Diff 25584

View Options

resources/sql/autopatches/20141007.phortuneprovider.sql

View Options

resources/sql/autopatches/20141007.phortuneproviderx.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

View Options

src/applications/phortune/controller/PhortuneMerchantViewController.php

View Options

src/applications/phortune/controller/PhortuneProviderActionController.php

View Options

src/applications/phortune/controller/PhortuneProviderController.php

View Options

src/applications/phortune/controller/PhortuneProviderEditController.php

View Options

src/applications/phortune/editor/PhortunePaymentProviderConfigEditor.php

View Options

src/applications/phortune/option/PhabricatorPhortuneConfigOptions.php

View Options

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

View Options

src/applications/phortune/provider/PhortuneBalancedPaymentProvider.php

View Options

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

View Options

src/applications/phortune/provider/PhortunePaymentProvider.php

View Options

src/applications/phortune/provider/PhortunePaypalPaymentProvider.php

View Options

src/applications/phortune/provider/PhortuneStripePaymentProvider.php

View Options

src/applications/phortune/provider/PhortuneTestPaymentProvider.php

View Options

src/applications/phortune/provider/PhortuneWePayPaymentProvider.php

View Options

src/applications/phortune/provider/tests/PhortunePaymentProviderTestCase.php

View Options

src/applications/phortune/provider/tests/PhortuneTestExtraPaymentProvider.php

View Options

src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php

View Options

src/applications/phortune/query/PhortunePaymentProviderConfigTransactionQuery.php

View Options

src/applications/phortune/storage/PhortunePaymentMethod.php

View Options

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

View Options

src/applications/phortune/storage/PhortunePaymentProviderConfigTransaction.php

Make payment providers a configurable property of Merchants in PhortuneClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25584

resources/sql/autopatches/20141007.phortuneprovider.sql

resources/sql/autopatches/20141007.phortuneproviderx.sql

src/__phutil_library_map__.php

src/applications/phortune/application/PhabricatorPhortuneApplication.php

src/applications/phortune/controller/PhortuneMerchantViewController.php

src/applications/phortune/controller/PhortuneProviderActionController.php

src/applications/phortune/controller/PhortuneProviderController.php

src/applications/phortune/controller/PhortuneProviderEditController.php

src/applications/phortune/editor/PhortunePaymentProviderConfigEditor.php

src/applications/phortune/option/PhabricatorPhortuneConfigOptions.php

src/applications/phortune/phid/PhortunePaymentProviderPHIDType.php

src/applications/phortune/provider/PhortuneBalancedPaymentProvider.php

src/applications/phortune/provider/PhortunePayPalPaymentProvider.php

src/applications/phortune/provider/PhortunePaymentProvider.php

src/applications/phortune/provider/PhortunePaypalPaymentProvider.php

src/applications/phortune/provider/PhortuneStripePaymentProvider.php

src/applications/phortune/provider/PhortuneTestPaymentProvider.php

src/applications/phortune/provider/PhortuneWePayPaymentProvider.php

src/applications/phortune/provider/__tests__/PhortunePaymentProviderTestCase.php

src/applications/phortune/provider/__tests__/PhortuneTestExtraPaymentProvider.php

src/applications/phortune/query/PhortunePaymentProviderConfigQuery.php

src/applications/phortune/query/PhortunePaymentProviderConfigTransactionQuery.php

src/applications/phortune/storage/PhortunePaymentMethod.php

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

src/applications/phortune/storage/PhortunePaymentProviderConfigTransaction.php

Make payment providers a configurable property of Merchants in Phortune
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/phortune/provider/tests/PhortunePaymentProviderTestCase.php

src/applications/phortune/provider/tests/PhortuneTestExtraPaymentProvider.php