Page MenuHomePhabricator

Adjust payment workflows to deal with merchants and configurable providers in Phortune
ClosedPublic

Authored by epriestley on Oct 7 2014, 8:08 PM.
Tags
None
Referenced Files
F18784655: D10652.id25581.diff
Mon, Oct 13, 2:04 PM
F18775617: D10652.id25585.diff
Fri, Oct 10, 7:37 PM
F18718262: D10652.id.diff
Mon, Sep 29, 3:25 PM
F18702745: D10652.diff
Sun, Sep 28, 1:19 AM
F18651209: D10652.diff
Sep 21 2025, 3:30 AM
F18504192: D10652.id.diff
Sep 4 2025, 11:39 PM
F18084512: D10652.id25581.diff
Aug 5 2025, 3:51 PM
F17890039: D10652.id25585.diff
Jul 29 2025, 3:08 AM
Subscribers

Details

Summary

Ref T2787. Builds on D10649 by rebining existing objects (carts, charges, etc) to merchantPHIDs and providerPHIDs instead of an implicit global merchant and weird global artifacts (providerType / providerKey).

Basically:

  • When you create something that users can pay for, you specify a merchant to control where the payment goes.
  • Accounts are install-wide, but payment methods are bound to merchants. This seems to do a reasonable job of balancing usability and technical concerns.
  • Replace a bunch of weird links between objects with standard PHIDs.
  • Improve "add payment method" flow.
Test Plan

Went through the Fund flow with Stripe and WePay, funding an initiative.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Adjust payment workflows to deal with merchants and configurable providers in Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 7 2014, 9:40 PM
This revision was automatically updated to reflect the committed changes.