I don't feel that this linter rule belongs in the ArcanistTextLinter. In fact, this linter rule is quite similar to the rules provided by ArcanistGeneratedLinter and ArcanistNoLintLinter and these classes could possibly be consolidated. I have moved this linter rule to a standalone ArcanistCommitLinter class (which could possibly do additional lints in the future).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rARC4e3df805844c: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
Moved existing test cases.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 3515 Build 3523: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think this functionality is useful to provide, but moving it elsewhere seems reasonable. The NoLint linter feels a little better to me, because the Generated linter might more complex eventually (see T784).