Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter
ClosedPublic
Actions

Authored by joshuaspence on Sep 11 2014, 12:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC4e3df805844c: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter

Summary

I don't feel that this linter rule belongs in the ArcanistTextLinter. In fact, this linter rule is quite similar to the rules provided by ArcanistGeneratedLinter and ArcanistNoLintLinter and these classes could possibly be consolidated. I have moved this linter rule to a standalone ArcanistCommitLinter class (which could possibly do additional lints in the future).

Test Plan

Moved existing test cases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 25185.Sep 11 2014, 12:29 PM

joshuaspence retitled this revision from to Remove `LINT_NO_COMMIT` from `ArcanistTextLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 11 2014, 12:29 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2509: Diff 25185.Sep 11 2014, 12:30 PM

I think this functionality is useful to provide, but moving it elsewhere seems reasonable. The NoLint linter feels a little better to me, because the Generated linter might more complex eventually (see T784).

Redo

joshuaspence retitled this revision from Remove `LINT_NO_COMMIT` from `ArcanistTextLinter` to Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter.Jan 3 2015, 4:41 AM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

epriestley accepted this revision.Jan 3 2015, 12:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 3 2015, 12:32 PM

Closed by commit rARC4e3df805844c: Move `LINT_NO_COMMIT` from `ArcanistTextLinter` to a new linter (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 5:49 AM

This revision was automatically updated to reflect the committed changes.