Paths

Table of Contentst

Differential D10433

Update the `JSONLint` API
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 4:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 1:10 AM

	Unknown Object (File)
	Wed, Dec 11, 6:19 AM

	Unknown Object (File)
	Sun, Dec 8, 9:13 AM

	Unknown Object (File)
	Sat, Dec 7, 1:42 PM

	Unknown Object (File)
	Dec 4 2024, 1:31 AM

	Unknown Object (File)
	Dec 3 2024, 1:18 PM

	Unknown Object (File)
	Nov 29 2024, 12:10 AM

	Unknown Object (File)
	Nov 28 2024, 8:37 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHUe7bc7ea2d12a: Update the `JSONLint` API

Summary

Update the JSONLint external to more closely resemble the upstream. D9623: Modify the JsonLint library to return `array` instead of `stdClass`. patched the library to return an array instead of stdClass, however this functionality now exists upstream as an optional mode (see 351e4350171d9c3af292cfb524dd83badb283e62).

I basically copied the external verbatim and then applied a sequence of patches (the initial patches required for D9622, plus D9633).

Test Plan

Ran unit tests.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25094.Sep 6 2014, 4:47 AM

joshuaspence retitled this revision from to Update the `JSONLint` API.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 4:47 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2451: Diff 25094.Sep 6 2014, 4:47 AM

joshuaspence updated this object.Sep 7 2014, 8:09 AM

joshuaspence edited edge metadata.

epriestley accepted this revision.Sep 7 2014, 6:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 7 2014, 6:01 PM

Closed by commit rPHUe7bc7ea2d12a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

externals/

jsonlint/

src/

Seld/

JsonLint/

59 lines

20 lines

src/

parser/

PhutilJSONParser.php

2 lines

Diff 25107

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Loading...

externals/jsonlint/src/Seld/JsonLint/Lexer.php

Loading...

src/parser/PhutilJSONParser.php

Loading...