Page MenuHomePhabricator
Differential D10433

Update the `JSONLint` API
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 4:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 9:58 PM
Unknown Object (File)
Sun, Apr 21, 3:57 PM
Unknown Object (File)
Wed, Apr 17, 2:09 PM
Unknown Object (File)
Thu, Apr 11, 7:13 AM
Unknown Object (File)
Tue, Apr 9, 1:47 PM
Unknown Object (File)
Sun, Apr 7, 7:48 AM
Unknown Object (File)
Sun, Mar 31, 10:08 PM
Unknown Object (File)
Sat, Mar 30, 9:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUe7bc7ea2d12a: Update the `JSONLint` API
Summary

Update the JSONLint external to more closely resemble the upstream. D9623: Modify the JsonLint library to return `array` instead of `stdClass`. patched the library to return an array instead of stdClass, however this functionality now exists upstream as an optional mode (see 351e4350171d9c3af292cfb524dd83badb283e62).

I basically copied the external verbatim and then applied a sequence of patches (the initial patches required for D9622, plus D9633).

Test Plan

Ran unit tests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 25094.Sep 6 2014, 4:47 AM
joshuaspence retitled this revision from to Update the `JSONLint` API.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 4:47 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2451: Diff 25094.Sep 6 2014, 4:47 AM
joshuaspence updated this object.Sep 7 2014, 8:09 AM
joshuaspence edited edge metadata.
epriestley accepted this revision.Sep 7 2014, 6:01 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2014, 6:01 PM
joshuaspence closed this revision.Sep 8 2014, 12:31 PM
joshuaspence updated this revision to Diff 25107.

Closed by commit rPHUe7bc7ea2d12a (authored by @joshuaspence).

Revision Contents
Changeset List

PathSize
externals/
jsonlint/
src/
Seld/
JsonLint/
59 lines
20 lines
src/
parser/
2 lines

Diff 25107

View Options

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Loading...
View Options

externals/jsonlint/src/Seld/JsonLint/Lexer.php

Loading...
View Options

src/parser/PhutilJSONParser.php

Loading...
Phabricator · Built by Phacility