Page MenuHomePhabricator

Allow passwords to be edited even if `account.editable` is `false`
ClosedPublic

Authored by epriestley on Aug 21 2014, 7:45 PM.
Tags
None
Referenced Files
F14006786: D10331.id24875.diff
Mon, Oct 28, 5:36 PM
Unknown Object (File)
Oct 11 2024, 2:50 PM
Unknown Object (File)
Oct 3 2024, 11:58 AM
Unknown Object (File)
Sep 20 2024, 8:32 PM
Unknown Object (File)
Sep 20 2024, 8:30 PM
Unknown Object (File)
Sep 20 2024, 8:29 PM
Unknown Object (File)
Sep 20 2024, 8:27 PM
Unknown Object (File)
Sep 15 2024, 3:18 AM
Subscribers

Details

Summary

Fixes T5900. We have some very old code here which does not let you update your password if the account.editable flag is set.

This was approximately introduced in D890, and I think it was mostly copy/pasted at that point. I'm not sure this ever really made sense. The option is not documented as affecting this, for example. In the modern environment of auth providers, it definitely does not make sense.

Instead, always allow users to change passwords if the install has a password provider configured.

Test Plan
  • Set account.editable to false.
  • Used a password reset link.

Diff Detail

Repository
rP Phabricator
Branch
editable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2322
Build 2326: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow passwords to be edited even if `account.editable` is `false`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2014, 10:26 PM
epriestley updated this revision to Diff 24875.

Closed by commit rP4a566f9e5d8d (authored by @epriestley).