HomePhabricator

Allow passwords to be edited even if `account.editable` is `false`

Description

Allow passwords to be edited even if account.editable is false

Summary:
Fixes T5900. We have some very old code here which does not let you update your password if the account.editable flag is set.

This was approximately introduced in D890, and I think it was mostly copy/pasted at that point. I'm not sure this ever really made sense. The option is not documented as affecting this, for example. In the modern environment of auth providers, it definitely does not make sense.

Instead, always allow users to change passwords if the install has a password provider configured.

Test Plan:

  • Set account.editable to false.
  • Used a password reset link.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5900

Differential Revision: https://secure.phabricator.com/D10331