Page MenuHomePhabricator
Differential D10240

Allow users to set notifications to "Email", "Notification", or "Ignore"
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 7:16 PM.
Tags
None
Referenced Files
F14005960: D10240.diff
Sun, Oct 27, 10:38 PM
F13987677: D10240.id.diff
Mon, Oct 21, 10:40 AM
F13986299: D10240.id24633.diff
Mon, Oct 21, 1:53 AM
F13976021: D10240.diff
Fri, Oct 18, 12:34 PM
F13955316: D10240.id24643.diff
Mon, Oct 14, 12:57 AM
Unknown Object (File)
Mon, Oct 7, 11:23 PM
Unknown Object (File)
Mon, Oct 7, 11:23 PM
Unknown Object (File)
Mon, Oct 7, 11:23 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5769: Add a setting to not trigger notifications when moving task across workboard columns
T5861: Improve the power of email settings
Commits
Restricted Diffusion Commit
rPc443913c0bbb: Allow users to set notifications to "Email", "Notification", or "Ignore"
Summary

Ref T5861. Ref T5769. If users don't care at all about something, allow them to ignore it.

We have some higher-volume notifications either built now (column changes) or coming (mentions) which users might reasonably want to ignore completely.

Test Plan

Ignored some notifications, then took appropraite actions. Saw my user culled from the notification subscriber list.

Screen_Shot_2014-08-12_at_12.08.40_PM.png (1×1 px, 255 KB)

Diff Detail

Repository
rP Phabricator
Branch
mail4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2179
Build 2183: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24633.Aug 12 2014, 7:16 PM
epriestley retitled this revision from to Allow users to set notifications to "Email", "Notification", or "Ignore".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added tasks: T5861: Improve the power of email settings, T5769: Add a setting to not trigger notifications when moving task across workboard columns.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 7:16 PM
Harbormaster completed remote builds in B2179: Diff 24633.Aug 12 2014, 7:17 PM
btrahan accepted this revision.Aug 12 2014, 7:19 PM
btrahan edited edge metadata.

Oh god I just had a waking nightmare about projects having settings for this stuff.

This revision is now accepted and ready to land.Aug 12 2014, 7:19 PM
epriestley added a comment.Aug 12 2014, 7:20 PM

yeah this could get out of hand real fast

epriestley closed this revision.Aug 12 2014, 7:29 PM
epriestley updated this revision to Diff 24643.

Closed by commit rPc443913c0bbb (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
89 lines
metamta/
storage/
4 lines
settings/
panel/
67 lines
storage/
5 lines
transactions/
editor/
1 line

Diff 24633

View Options

src/applications/feed/PhabricatorFeedStoryPublisher.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility