Page MenuHomePhabricator

Allow users to set notifications to "Email", "Notification", or "Ignore"
ClosedPublic

Authored by epriestley on Aug 12 2014, 7:16 PM.
Tags
None
Referenced Files
F13447230: D10240.id.diff
Sat, Jul 13, 3:01 AM
F13446753: D10240.diff
Sat, Jul 13, 2:19 AM
F13443937: D10240.id24633.diff
Fri, Jul 12, 8:52 PM
F13429224: D10240.diff
Wed, Jul 10, 3:02 AM
F13407579: D10240.id24643.diff
Fri, Jul 5, 11:57 PM
F13405771: D10240.diff
Fri, Jul 5, 3:44 PM
F13347512: D10240.diff
Sat, Jun 22, 11:07 AM
F13346465: D10240.id24633.diff
Fri, Jun 21, 3:47 PM
Subscribers

Details

Summary

Ref T5861. Ref T5769. If users don't care at all about something, allow them to ignore it.

We have some higher-volume notifications either built now (column changes) or coming (mentions) which users might reasonably want to ignore completely.

Test Plan

Ignored some notifications, then took appropraite actions. Saw my user culled from the notification subscriber list.

Screen_Shot_2014-08-12_at_12.08.40_PM.png (1×1 px, 255 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow users to set notifications to "Email", "Notification", or "Ignore".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
btrahan edited edge metadata.

Oh god I just had a waking nightmare about projects having settings for this stuff.

This revision is now accepted and ready to land.Aug 12 2014, 7:19 PM

yeah this could get out of hand real fast

epriestley updated this revision to Diff 24643.

Closed by commit rPc443913c0bbb (authored by @epriestley).