Allow searching tasks by has-assignee status
Needs RevisionPublic
Actions

Authored by skyronic on Jul 30 2014, 1:12 PM.

Details

Reviewers

epriestley
shadowhand

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5733: Add option for "show only assigned" tasks in search

Summary

The previous search system allowed you to filter only unassigned
issues. However some people (T5733) might prefer to show only
assigned tasks which match the query.

Also please note that this requires that the old "Show only unassigned
tasks" checkbox be removed as it becomes redundant.

Test Plan

Ran queries with multiple cases, and it all ran fine.

Diff Detail

Repository

rP Phabricator

Branch

assignee-search

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/applications/maniphest/query/ManiphestTaskQuery.php:486	TXT6	Trailing Whitespace

Unit

No Test Coverage

Build Status

Buildable 1933
Build 1934: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

skyronic updated this revision to Diff 24230.Jul 30 2014, 1:12 PM

skyronic retitled this revision from to Allow searching tasks by has-assignee status.

skyronic updated this object.

skyronic edited the test plan for this revision. (Show Details)

skyronic added a reviewer: epriestley.

skyronic added a subscriber: shadowhand.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 30 2014, 1:12 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

skyronic added a task: T5733: Add option for "show only assigned" tasks in search.Jul 30 2014, 1:13 PM

Harbormaster completed remote builds in B1933: Diff 24230.Jul 30 2014, 1:14 PM

I understand I need to write a migration to migrate the "withAssigned" checkbox to reflect in the other query. I will do this if there's a chance that this feature will be merged in.

I don't really like this approach to the UI (especially because it puts two related controls a huge distance away). Even if they were adjacent, this still feels hard to use.

I don't have a good alternative UI, which is why I'd rather pursue alternatives mentioned in T5733 rather than implement this per se. T4100 potentially offers another attack on this. The best option would be coming up with a better UI than two disconnected controls, but I can't immediately come up with one.

Basically, this adds a bunch of complexity to provide a not-great-feeling solution to a rare problem. Maybe it's really the best solution, but I want to wait until at least after T4100 before pursuing it.

This revision now requires changes to proceed.Jul 30 2014, 8:51 PM

This works as expected.

As an alternative UI to what is currently implemented, why not do this?

Screen_Shot_2014-08-26_at_12.43.34.png (149×358 px, 15 KB)

It matches the existing UI much better, though it doesn't allow for the "unassigned" option, but considering that the current sorting puts unassigned tasks first, I don't consider that a valid concern.