Paths

Table of Contentst

Diffusion Phabricator ff6bfe387d47

Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with…
ff6bfe387d47
Actions

Tags

None

Referenced Files

	F1057989: Screen Shot 2016-01-09 at 1.46.17 PM.png
	Jan 9 2016, 11:40 PM

	F1057988: Screen Shot 2016-01-09 at 1.44.52 PM.png
	Jan 9 2016, 11:40 PM

Subscribers

None

Description

Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with width or height

Summary: Ref T10110. If an image had width or height, we would accidentally not give it an $image_class.

Test Plan:

Screen Shot 2016-01-09 at 1.44.52 PM.png (1×967 px, 696 KB)

Screen Shot 2016-01-09 at 1.46.17 PM.png (889×1 px, 321 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10110

Differential Revision: https://secure.phabricator.com/D14983

Details

Provenance

epriestley	Authored on
epriestley	Pushed on Jan 9 2016, 11:40 PM

Reviewer

Differential Revision

D14983: Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`

Parents

rP67ac356b0327: Modernize `bin/files migrate` and fix behavior on chunk engines

Branches

Unknown

Tags

Unknown

Tasks

T10110: Floating images in Phriction can make everything else afterwards float... forever

Build Status

Buildable 10028
Build 12128: Run Core Tests

Event Timeline

epriestley committed rPff6bfe387d47: Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with… (authored by epriestley).Jan 9 2016, 11:40 PM

epriestley added a task: T10110: Floating images in Phriction can make everything else afterwards float... forever.

Harbormaster completed building B10028: rPff6bfe387d47: Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with….Jan 9 2016, 11:41 PM

Changes (1)

Path

Size

src/

applications/

files/

markup/

PhabricatorEmbedFileRemarkupRule.php

rPff6bfe387d47

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...