Page MenuHomePhabricator

Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`
ClosedPublic

Authored by epriestley on Jan 9 2016, 9:49 PM.
Tags
None
Referenced Files
F15537977: D14983.id36193.diff
Thu, Apr 24, 5:01 PM
F15534685: D14983.diff
Thu, Apr 24, 1:17 AM
F15529237: D14983.id36192.diff
Tue, Apr 22, 6:07 PM
F15518707: D14983.id36194.diff
Sat, Apr 19, 3:58 PM
F15518345: D14983.id.diff
Sat, Apr 19, 12:47 PM
F15516487: D14983.diff
Fri, Apr 18, 7:10 PM
F15505942: D14983.diff
Tue, Apr 15, 7:04 AM
F15473451: D14983.id36192.diff
Sat, Apr 5, 10:09 PM
Subscribers
None

Details

Summary

Ref T10110. If an image had width or height, we would accidentally not give it an $image_class.

Test Plan

Screen Shot 2016-01-09 at 1.44.52 PM.png (1×967 px, 696 KB)

Screen Shot 2016-01-09 at 1.46.17 PM.png (889×1 px, 321 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Remarkup images inline-block layout so "layout=inline" works.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

This is wrong.

epriestley edited edge metadata.
  • Proper fix.
epriestley retitled this revision from Give Remarkup images inline-block layout so "layout=inline" works to Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`.Jan 9 2016, 9:56 PM
epriestley updated this object.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2016, 10:49 PM
This revision was automatically updated to reflect the committed changes.