Page MenuHomePhabricator
Differential D14983

Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`
ClosedPublic
Actions

Authored by epriestley on Jan 9 2016, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:56 AM
Unknown Object (File)
Sat, Apr 27, 12:17 PM
Unknown Object (File)
Fri, Apr 19, 10:01 AM
Unknown Object (File)
Fri, Apr 19, 10:01 AM
Unknown Object (File)
Fri, Apr 19, 10:01 AM
Unknown Object (File)
Fri, Apr 19, 10:01 AM
Unknown Object (File)
Wed, Apr 17, 10:03 AM
Unknown Object (File)
Sun, Apr 14, 4:01 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10110: Floating images in Phriction can make everything else afterwards float... forever
Commits
Restricted Diffusion Commit
rPff6bfe387d47: Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with…
Summary

Ref T10110. If an image had width or height, we would accidentally not give it an $image_class.

Test Plan

Screen Shot 2016-01-09 at 1.44.52 PM.png (1×967 px, 696 KB)

Screen Shot 2016-01-09 at 1.46.17 PM.png (889×1 px, 321 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36192.Jan 9 2016, 9:49 PM
epriestley retitled this revision from to Give Remarkup images inline-block layout so "layout=inline" works.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10110: Floating images in Phriction can make everything else afterwards float... forever.
Herald edited edge metadata. · View Herald TranscriptJan 9 2016, 9:49 PM
epriestley planned changes to this revision.Jan 9 2016, 9:52 PM

This is wrong.

epriestley updated this revision to Diff 36193.Jan 9 2016, 9:55 PM
epriestley edited edge metadata.
  • Proper fix.
epriestley retitled this revision from Give Remarkup images inline-block layout so "layout=inline" works to Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`.Jan 9 2016, 9:56 PM
epriestley updated this object.
epriestley mentioned this in T10110: Floating images in Phriction can make everything else afterwards float... forever.
epriestley updated this object.Jan 9 2016, 10:04 PM
chad accepted this revision.Jan 9 2016, 10:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2016, 10:49 PM
Closed by commit rPff6bfe387d47: Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with… (authored by epriestley, committed by epriestley). · Explain WhyJan 9 2016, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
files/
markup/
4 lines

Diff 36194

View Options

src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php

Loading...
Phabricator · Built by Phacility