Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
F19942778: D17653.id.diff
Wed, Apr 15, 9:55 PM
F19818738: D17653.id42458.diff
Mar 5 2026, 11:51 PM
F19701542: D17653.id42458.diff
Feb 10 2026, 10:40 PM
F19601700: D17653.id.diff
Feb 3 2026, 5:15 AM
F19534150: D17653.diff
Jan 20 2026, 10:41 PM
F19532880: D17653.id42458.diff
Jan 20 2026, 2:05 PM
F19529078: D17653.id42458.diff
Jan 19 2026, 2:04 PM
F19051384: D17653.diff
Nov 28 2025, 12:44 AM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable