Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
F18229943: D17653.id42459.diff
Wed, Aug 20, 11:46 AM
F18229942: D17653.id42458.diff
Wed, Aug 20, 11:46 AM
F18229941: D17653.id.diff
Wed, Aug 20, 11:46 AM
F18220460: D17653.diff
Tue, Aug 19, 2:49 PM
F18219573: D17653.id42458.diff
Tue, Aug 19, 11:56 AM
F18094533: D17653.diff
Thu, Aug 7, 10:11 PM
F18088163: D17653.diff
Wed, Aug 6, 7:07 AM
F17946367: D17653.id42459.diff
Thu, Jul 31, 2:18 PM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable