Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:33 AM
Unknown Object (File)
Fri, Apr 19, 6:23 PM
Unknown Object (File)
Apr 8 2024, 3:55 PM
Unknown Object (File)
Mar 21 2024, 1:08 AM
Unknown Object (File)
Feb 24 2024, 4:52 PM
Unknown Object (File)
Feb 15 2024, 6:04 AM
Unknown Object (File)
Feb 10 2024, 12:31 PM
Unknown Object (File)
Jan 30 2024, 3:01 PM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable