Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 6:18 PM
Unknown Object (File)
Dec 14 2024, 9:10 AM
Unknown Object (File)
Dec 6 2024, 11:00 PM
Unknown Object (File)
Nov 30 2024, 1:15 AM
Unknown Object (File)
Nov 27 2024, 11:24 PM
Unknown Object (File)
Nov 25 2024, 12:22 PM
Unknown Object (File)
Nov 24 2024, 3:18 PM
Unknown Object (File)
Nov 23 2024, 4:44 AM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable