Page MenuHomePhabricator

Fix an issue where rejecting reviewers weren't powerful enough
ClosedPublic

Authored by epriestley on Apr 11 2017, 4:52 PM.
Tags
None
Referenced Files
F18798602: D17653.id.diff
Fri, Oct 17, 7:11 AM
F18733534: D17653.id.diff
Sep 30 2025, 10:36 PM
F18732099: D17653.id.diff
Sep 30 2025, 4:18 PM
F18719380: D17653.diff
Sep 29 2025, 5:05 PM
F18699058: D17653.id42458.diff
Sep 27 2025, 12:18 PM
F18617350: D17653.diff
Sep 14 2025, 8:59 PM
F18602228: D17653.diff
Sep 13 2025, 2:34 PM
F18602227: D17653.diff
Sep 13 2025, 2:34 PM
Subscribers
None

Details

Summary

Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan
  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable