HomePhabricator

In Differential mail, hide "summary" if empty and show "test plan" if nonempty

Authored by epriestley.

Description

In Differential mail, hide "summary" if empty and show "test plan" if nonempty

Summary:
Ref T4481. Summary is optional, but we currently always render it.

We previously rendered TEST PLAN. I wanted to see if anyone missed it. I miss it a little bit, and it sounds like @spicyj misses it. Restore it.

Test Plan:

$ ./bin/mail show-outbound --id 15232
...
BODY
epriestley created this revision.
epriestley added reviewers: The Bureaucracy, duck.
epriestley added a subscriber: duck.

TEST PLAN
  more j

REVISION DETAIL
  http://local.aphront.com:8080/D1042

AFFECTED FILES
  number_j.txt

CHANGE DETAILS
  Index: number_j.txt
  ===================================================================
  --- number_j.txt
  +++ number_j.txt
  @@ -137,3 +137,4 @@
   j
   j
   j
  +j

To: epriestley, duck, Sebastiangarcia, Ahmedsmoore, nathanhthomas, chewnicorn
Cc: duck

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: aran, epriestley, spicyj

Maniphest Tasks: T4481

Differential Revision: https://secure.phabricator.com/D8531

Event Timeline