Page MenuHomePhabricator

In Differential mail, hide "summary" if empty and show "test plan" if nonempty
ClosedPublic

Authored by epriestley on Mar 14 2014, 1:37 PM.

Details

Summary

Ref T4481. Summary is optional, but we currently always render it.

We previously rendered TEST PLAN. I wanted to see if anyone missed it. I miss it a little bit, and it sounds like @spicyj misses it. Restore it.

Test Plan
$ ./bin/mail show-outbound --id 15232
...
BODY
epriestley created this revision.
epriestley added reviewers: The Bureaucracy, duck.
epriestley added a subscriber: duck.

TEST PLAN
  more j

REVISION DETAIL
  http://local.aphront.com:8080/D1042

AFFECTED FILES
  number_j.txt

CHANGE DETAILS
  Index: number_j.txt
  ===================================================================
  --- number_j.txt
  +++ number_j.txt
  @@ -137,3 +137,4 @@
   j
   j
   j
  +j

To: epriestley, duck, Sebastiangarcia, Ahmedsmoore, nathanhthomas, chewnicorn
Cc: duck

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20240.Mar 14 2014, 1:37 PM
epriestley retitled this revision from to In Differential mail, hide "summary" if empty and show "test plan" if nonempty.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: sophiebits.
btrahan accepted this revision.Mar 14 2014, 5:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 5:36 PM
epriestley closed this revision.Mar 14 2014, 6:53 PM
epriestley updated this revision to Diff 20254.

Closed by commit rPefcca310c2cf (authored by @epriestley).