Differential D8531

In Differential mail, hide "summary" if empty and show "test plan" if nonempty
ClosedPublic
Actions

Authored by epriestley on Mar 14 2014, 1:37 PM.

Tags

None

Referenced Files

	F15331807: D8531.diff
	Fri, Mar 7, 1:56 PM

	Unknown Object (File)
	Mon, Mar 3, 7:00 PM

	Unknown Object (File)
	Mon, Mar 3, 7:00 PM

	Unknown Object (File)
	Wed, Feb 19, 7:59 AM

	Unknown Object (File)
	Fri, Feb 14, 10:57 PM

	Unknown Object (File)
	Fri, Feb 14, 10:57 PM

	Unknown Object (File)
	Sun, Feb 9, 11:56 AM

	Unknown Object (File)
	Sun, Feb 9, 11:56 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T4481: Differential Update Feedback / Rough Edges / Status

Commits

Restricted Diffusion Commit
rPefcca310c2cf: In Differential mail, hide "summary" if empty and show "test plan" if nonempty

Summary

Ref T4481. Summary is optional, but we currently always render it.

We previously rendered TEST PLAN. I wanted to see if anyone missed it. I miss it a little bit, and it sounds like @spicyj misses it. Restore it.

Test Plan

$ ./bin/mail show-outbound --id 15232
...
BODY
epriestley created this revision.
epriestley added reviewers: The Bureaucracy, duck.
epriestley added a subscriber: duck.

TEST PLAN
  more j

REVISION DETAIL
  http://local.aphront.com:8080/D1042

AFFECTED FILES
  number_j.txt

CHANGE DETAILS
  Index: number_j.txt
  ===================================================================
  --- number_j.txt
  +++ number_j.txt
  @@ -137,3 +137,4 @@
   j
   j
   j
  +j

To: epriestley, duck, Sebastiangarcia, Ahmedsmoore, nathanhthomas, chewnicorn
Cc: duck

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20240.Mar 14 2014, 1:37 PM

epriestley retitled this revision from to In Differential mail, hide "summary" if empty and show "test plan" if nonempty.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4481: Differential Update Feedback / Rough Edges / Status.

epriestley added a subscriber: sophiebits.

Herald added subscribers: epriestley, aran.Mar 14 2014, 1:37 PM

btrahan accepted this revision.Mar 14 2014, 5:36 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 14 2014, 5:36 PM

Closed by commit rPefcca310c2cf (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

16 lines

Diff 20254

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...