HomePhabricator

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet

Description

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet

Summary:
In Diffusion, the "Tags" view may read commits which haven't imported or parsed yet, and thus don't have loadable objects.

Most of this logic tests for if ($commit), but the author part did not. Instead, don't render author information if $commit is not present.

Test Plan:

  • Loaded tags view with commits present.
  • Faked $commit = null;, loaded tag view, got this instead of a fatal:

Screen Shot 2017-07-28 at 10.39.21 AM.png (903×1 px, 113 KB)

Reviewers: chad, amckinley

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18290

Details

Provenance
epriestleyAuthored on Jul 28 2017, 5:37 PM
epriestleyPushed on Jul 28 2017, 5:43 PM
Reviewer
chad
Differential Revision
D18290: Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet
Parents
rPd114bc4a19bd: Fix dark mode highlight in Timeline
Branches
Unknown
Tags
Unknown
Build Status
Buildable 17824
Build 23940: Run Core Tests