Page MenuHomePhabricator

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet
ClosedPublic

Authored by epriestley on Jul 28 2017, 5:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 3:09 AM
Unknown Object (File)
Dec 24 2023, 1:45 PM
Unknown Object (File)
Dec 20 2023, 1:11 PM
Unknown Object (File)
Nov 30 2023, 6:27 AM
Unknown Object (File)
Nov 19 2023, 11:04 AM
Unknown Object (File)
Oct 30 2023, 11:14 AM
Unknown Object (File)
Oct 23 2023, 9:14 PM
Unknown Object (File)
Oct 22 2023, 12:01 PM
Subscribers
None
Tokens
"Like" token, awarded by jlap.

Details

Summary

In Diffusion, the "Tags" view may read commits which haven't imported or parsed yet, and thus don't have loadable objects.

Most of this logic tests for if ($commit), but the author part did not. Instead, don't render author information if $commit is not present.

Test Plan
  • Loaded tags view with commits present.
  • Faked $commit = null;, loaded tag view, got this instead of a fatal:

Screen Shot 2017-07-28 at 10.39.21 AM.png (903×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable