Page MenuHomePhabricator

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet
ClosedPublic

Authored by epriestley on Jul 28 2017, 5:41 PM.
Tags
None
Referenced Files
F15472240: D18290.id.diff
Sat, Apr 5, 11:58 AM
F15469589: D18290.diff
Fri, Apr 4, 2:55 PM
F15421287: D18290.diff
Fri, Mar 21, 10:19 PM
F15403981: D18290.id43984.diff
Tue, Mar 18, 5:48 AM
F15335587: D18290.diff
Sat, Mar 8, 4:35 PM
Unknown Object (File)
Feb 18 2025, 12:31 PM
Unknown Object (File)
Feb 9 2025, 4:30 AM
Unknown Object (File)
Feb 9 2025, 4:30 AM
Subscribers
None
Tokens
"Like" token, awarded by jlap.

Details

Summary

In Diffusion, the "Tags" view may read commits which haven't imported or parsed yet, and thus don't have loadable objects.

Most of this logic tests for if ($commit), but the author part did not. Instead, don't render author information if $commit is not present.

Test Plan
  • Loaded tags view with commits present.
  • Faked $commit = null;, loaded tag view, got this instead of a fatal:

Screen Shot 2017-07-28 at 10.39.21 AM.png (903×1 px, 113 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable