Make translation, timezone and pronoun into real settings
ebd8f3c9874b
Actions

Description

Make translation, timezone and pronoun into real settings

Summary:
Ref T4103. These are currently stored on the user, for historic/performance reasons.

Since I want administrators to be able to set defaults for translations and timezones at a minimum and there's no longer a meaningful performance penalty for moving them off the user record, turn them into real preferences and then nuke the columns.

Test Plan:

Set settings to unusual values.
Ran migrations.
Verified my unusual settings survived.
Created a new user.
Edited all settings with old and new UIs.
Reconciled client/server timezone disagreement.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16005

Details

Provenance

epriestley	Authored on Jun 1 2016, 11:17 PM
epriestley	Pushed on Jun 2 2016, 1:29 PM

Reviewer

chad

Differential Revision

D16005: Make translation, timezone and pronoun into real settings

Parents

rPedfc6a69345a: Convert some loadPreferences() to getUserSetting()

Branches

Unknown

Tags

Unknown

Tasks

T4103: Implement "Role Profiles" to provide search, homepage and application defaults

Build Status

Buildable 12403
Build 15702: Run Core Tests

Event Timeline

epriestley committed rPebd8f3c9874b: Make translation, timezone and pronoun into real settings (authored by epriestley).Jun 2 2016, 1:29 PM

epriestley added a task: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

Harbormaster completed building B12403: rPebd8f3c9874b: Make translation, timezone and pronoun into real settings.Jun 2 2016, 1:31 PM

Changes (19)

Path

Size

resources/

sql/

autopatches/

20160601.user.02.copyprefs.php

	20160601.user.03.removetime.sql
	20150602.mlist.1.sql

	20160601.user.04.removetranslation.sql
	20150602.mlist.1.sql

	20160601.user.05.removesex.sql
	20150602.mlist.1.sql

src/

__phutil_library_map__.php

applications/

calendar/

__tests__/

CalendarTimeUtilTestCase.php

metamta/

storage/

PhabricatorMetaMTAMail.php

people/

storage/

PhabricatorUser.php

settings/

controller/

PhabricatorSettingsTimezoneController.php

editor/

PhabricatorSettingsEditEngine.php

panel/

PhabricatorAccountSettingsPanel.php

PhabricatorDateTimeSettingsPanel.php

setting/

PhabricatorOptionGroupSetting.php

PhabricatorPronounSetting.php

PhabricatorSelectSetting.php

PhabricatorTimezoneSetting.php

PhabricatorTranslationSetting.php

infrastructure/

time/

__tests__/

PhabricatorTimeTestCase.php

view/

__tests__/

PhabricatorLocalTimeTestCase.php

rPebd8f3c9874b

View Options

resources/sql/autopatches/20160601.user.02.copyprefs.php

View Options

resources/sql/autopatches/20160601.user.03.removetime.sql

View Options

resources/sql/autopatches/20160601.user.04.removetranslation.sql

View Options

resources/sql/autopatches/20160601.user.05.removesex.sql

View Options

src/__phutil_library_map__.php

View Options

src/applications/calendar/tests/CalendarTimeUtilTestCase.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

View Options

src/applications/settings/editor/PhabricatorSettingsEditEngine.php

View Options

src/applications/settings/panel/PhabricatorAccountSettingsPanel.php

View Options

src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php

View Options

src/applications/settings/setting/PhabricatorOptionGroupSetting.php

View Options

src/applications/settings/setting/PhabricatorPronounSetting.php

View Options

src/applications/settings/setting/PhabricatorSelectSetting.php

View Options

src/applications/settings/setting/PhabricatorTimezoneSetting.php

View Options

src/applications/settings/setting/PhabricatorTranslationSetting.php

View Options

src/infrastructure/time/tests/PhabricatorTimeTestCase.php

View Options

src/view/tests/PhabricatorLocalTimeTestCase.php

Make translation, timezone and pronoun into real settingsebd8f3c9874bActions

Description

Details

Event Timeline

Changes (19)

rPebd8f3c9874b

resources/sql/autopatches/20160601.user.02.copyprefs.php

resources/sql/autopatches/20160601.user.03.removetime.sql

resources/sql/autopatches/20160601.user.04.removetranslation.sql

resources/sql/autopatches/20160601.user.05.removesex.sql

src/__phutil_library_map__.php

src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

src/applications/people/storage/PhabricatorUser.php

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

src/applications/settings/editor/PhabricatorSettingsEditEngine.php

src/applications/settings/panel/PhabricatorAccountSettingsPanel.php

src/applications/settings/panel/PhabricatorDateTimeSettingsPanel.php

src/applications/settings/setting/PhabricatorOptionGroupSetting.php

src/applications/settings/setting/PhabricatorPronounSetting.php

src/applications/settings/setting/PhabricatorSelectSetting.php

src/applications/settings/setting/PhabricatorTimezoneSetting.php

src/applications/settings/setting/PhabricatorTranslationSetting.php

src/infrastructure/time/__tests__/PhabricatorTimeTestCase.php

src/view/__tests__/PhabricatorLocalTimeTestCase.php

Make translation, timezone and pronoun into real settings
ebd8f3c9874b
Actions

src/applications/calendar/tests/CalendarTimeUtilTestCase.php

src/infrastructure/time/tests/PhabricatorTimeTestCase.php

src/view/tests/PhabricatorLocalTimeTestCase.php