Page MenuHomePhabricator

Make translation, timezone and pronoun into real settings
ClosedPublic

Authored by epriestley on Jun 1 2016, 11:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 11:48 AM
Unknown Object (File)
Feb 15 2024, 3:16 PM
Unknown Object (File)
Feb 3 2024, 10:21 AM
Unknown Object (File)
Jan 23 2024, 2:43 PM
Unknown Object (File)
Jan 16 2024, 3:13 AM
Unknown Object (File)
Jan 4 2024, 2:31 PM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Unknown Object (File)
Dec 27 2023, 7:14 AM
Subscribers
None

Details

Summary

Ref T4103. These are currently stored on the user, for historic/performance reasons.

Since I want administrators to be able to set defaults for translations and timezones at a minimum and there's no longer a meaningful performance penalty for moving them off the user record, turn them into real preferences and then nuke the columns.

Test Plan
  • Set settings to unusual values.
  • Ran migrations.
  • Verified my unusual settings survived.
  • Created a new user.
  • Edited all settings with old and new UIs.
  • Reconciled client/server timezone disagreement.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make translation, timezone and pronoun into real settings.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
src/applications/metamta/storage/PhabricatorMetaMTAMail.php
167

This has been unused for a long time, it just never got cleaned up.

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
119–121

I guess "GMT" is deprecated and "UTC" is the new hotness.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 2 2016, 12:17 AM
This revision was automatically updated to reflect the committed changes.