HomePhabricator

Make new DiffInline code handle most "delete" operations

Description

Make new DiffInline code handle most "delete" operations

Summary:
Ref T12616. This moves the delete actions to the new, more stateful way of doing things.

These are a little tricky because you can click "Delete" on an inline, but you can also click "Delete" from the preview area at the bottom of the page. If you do, the inline you are deleting may or may not be present on the page.

This has a few bugs -- notably, deleting from the preview without interacting with the on-page inline first won't actually delete the on-page inline yet -- but nothing too serious.

Test Plan: Deleted inlines, undid deletion, deleted from preview.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616

Differential Revision: https://secure.phabricator.com/D17890

Details

Provenance
epriestleyAuthored on May 15 2017, 10:03 PM
epriestleyPushed on May 16 2017, 1:21 PM
Reviewer
chad
Differential Revision
D17890: Make new DiffInline code handle most "delete" operations
Parents
rP3c18cb77fb66: Move inline "done" checkboxing to DiffInline
Branches
Unknown
Tags
Unknown
Tasks
T12616: Modernize display code for inline comments
Build Status
Buildable 16980
Build 22697: Run Core Tests