Page MenuHomePhabricator

Make new DiffInline code handle most "delete" operations
ClosedPublic

Authored by epriestley on May 15 2017, 10:10 PM.
Tags
None
Referenced Files
F11048290: D17890.diff
Fri, Aug 19, 2:38 AM
F11047741: D17890.id43052.diff
Thu, Aug 18, 8:59 PM
Unknown Object (File)
Tue, Aug 16, 4:31 PM
Unknown Object (File)
Sat, Aug 13, 8:06 AM
Unknown Object (File)
Sun, Aug 7, 3:01 PM
Unknown Object (File)
Sun, Aug 7, 12:37 AM
Unknown Object (File)
Sun, Aug 7, 12:21 AM
Unknown Object (File)
Wed, Aug 3, 10:57 PM
Subscribers
None

Details

Summary

Ref T12616. This moves the delete actions to the new, more stateful way of doing things.

These are a little tricky because you can click "Delete" on an inline, but you can also click "Delete" from the preview area at the bottom of the page. If you do, the inline you are deleting may or may not be present on the page.

This has a few bugs -- notably, deleting from the preview without interacting with the on-page inline first won't actually delete the on-page inline yet -- but nothing too serious.

Test Plan

Deleted inlines, undid deletion, deleted from preview.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable