HomePhabricator

Proxy Diffusion Conduit API calls

Description

Proxy Diffusion Conduit API calls

Summary:
Fixes T7020. When an external user makes a Conduit request to Diffusion but the repository isn't hosted locally, we need to proxy it.

This also adds a guard layer to prevent requests from getting infinitely proxied inside the cluster.

In "trivial" configurations (where the repository is a service repository, but the service is on the local device) I'm making us always proxy anyway. This basically makes it reasonable to test this stuff (otherwise you'd have to set up two different installs) and this configuration doesn't make much sense in real life (if you're using multiple machines, making one a dedicating daemons+repo box is almost certainly the most reasonable configuration, even for a cluster size of 2).

Test Plan:

  • With a service-hosted repository, made Diffusion conduit calls and browsed the UI. Verified requests got proxied once, then resovled.
  • With a non-service repository, made Diffusion conduit calls and browsed UI. Verified requests were handled in-process immediately.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7020

Differential Revision: https://secure.phabricator.com/D11475

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jan 23 2015, 9:30 PM
Reviewer
btrahan
Differential Revision
D11475: Proxy Diffusion Conduit API calls
Parents
rP7c2474bef756: Move Conduit client construction logic into Repository
Branches
Unknown
Tags
Unknown
Tasks
T7020: Proxy Diffusion Conduit requests