Page MenuHomePhabricator

Proxy Diffusion Conduit API calls
ClosedPublic

Authored by epriestley on Jan 23 2015, 1:10 PM.
Tags
None
Referenced Files
F13095888: D11475.diff
Thu, Apr 25, 1:19 PM
Unknown Object (File)
Mon, Apr 22, 4:58 AM
Unknown Object (File)
Mon, Apr 8, 9:58 AM
Unknown Object (File)
Thu, Mar 28, 1:16 AM
Unknown Object (File)
Mar 27 2024, 3:40 AM
Unknown Object (File)
Mar 25 2024, 11:38 AM
Unknown Object (File)
Mar 25 2024, 11:38 AM
Unknown Object (File)
Mar 25 2024, 11:38 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T7020: Proxy Diffusion Conduit requests
Commits
Restricted Diffusion Commit
rPd94d1da61098: Proxy Diffusion Conduit API calls
Summary

Fixes T7020. When an external user makes a Conduit request to Diffusion but the repository isn't hosted locally, we need to proxy it.

This also adds a guard layer to prevent requests from getting infinitely proxied inside the cluster.

In "trivial" configurations (where the repository is a service repository, but the service is on the local device) I'm making us always proxy anyway. This basically makes it reasonable to test this stuff (otherwise you'd have to set up two different installs) and this configuration doesn't make much sense in real life (if you're using multiple machines, making one a dedicating daemons+repo box is almost certainly the most reasonable configuration, even for a cluster size of 2).

Test Plan
  • With a service-hosted repository, made Diffusion conduit calls and browsed the UI. Verified requests got proxied once, then resovled.
  • With a non-service repository, made Diffusion conduit calls and browsed UI. Verified requests were handled in-process immediately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable