HomePhabricator

Herald - fix change type bug

Description

Herald - fix change type bug

Summary: wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan: created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4756

Differential Revision: https://secure.phabricator.com/D8724

Details

Provenance
btrahanAuthored on
btrahanPushed on Apr 8 2014, 6:58 PM
Reviewer
epriestley
Differential Revision
D8724: Herald - fix change type bug
Parents
rP582ec5446532: Add a checkbox to the LDAP auth configuration UI to "Always Search"
Branches
Unknown
Tags
Unknown
Tasks
T4756: Herald "ref change type has bit X" not working

Event Timeline