Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
F15404015: D8724.id20689.diff
Tue, Mar 18, 5:53 AM
F15379143: D8724.id.diff
Thu, Mar 13, 6:58 PM
F15375281: D8724.id20687.diff
Wed, Mar 12, 10:23 PM
F15334341: D8724.id20689.diff
Sat, Mar 8, 8:21 AM
F15323519: D8724.id20687.diff
Fri, Mar 7, 12:38 AM
Unknown Object (File)
Tue, Feb 25, 4:37 PM
Unknown Object (File)
Tue, Feb 25, 4:37 PM
Unknown Object (File)
Tue, Feb 25, 3:01 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).