Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
F15484558: D8724.id20689.diff
Wed, Apr 9, 7:01 PM
F15456540: D8724.id20687.diff
Sun, Mar 30, 10:25 AM
F15453320: D8724.id.diff
Sat, Mar 29, 10:53 AM
F15443755: D8724.diff
Thu, Mar 27, 6:00 AM
F15426603: D8724.id20689.diff
Sun, Mar 23, 9:55 AM
F15404015: D8724.id20689.diff
Mar 18 2025, 5:53 AM
F15379143: D8724.id.diff
Mar 13 2025, 6:58 PM
F15375281: D8724.id20687.diff
Mar 12 2025, 10:23 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).