Page MenuHomePhabricator

Herald - fix change type bug
ClosedPublic

Authored by btrahan on Apr 8 2014, 6:54 PM.
Tags
None
Referenced Files
F13083680: D8724.diff
Wed, Apr 24, 10:41 PM
Unknown Object (File)
Tue, Apr 16, 1:37 PM
Unknown Object (File)
Sun, Apr 14, 2:14 AM
Unknown Object (File)
Thu, Apr 11, 9:52 AM
Unknown Object (File)
Sat, Apr 6, 2:06 AM
Unknown Object (File)
Sat, Apr 6, 12:31 AM
Unknown Object (File)
Fri, Apr 5, 11:35 PM
Unknown Object (File)
Mar 22 2024, 7:43 PM
Subscribers

Details

Summary

wasn't working due to some type issues. Fixes T4756. I also made it display nicer while I was debugging this.

Test Plan

created a herald rule to block changes that added refs. git tag -a "test" -m "test test"; git push origin test got me blocked!

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Herald - fix change type bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
This revision is now accepted and ready to land.Apr 8 2014, 6:57 PM
btrahan updated this revision to Diff 20689.

Closed by commit rPd5ded805b2d3 (authored by @btrahan).