HomePhabricator

Allow any inline in the document to be queried by ID

Description

Allow any inline in the document to be queried by ID

Summary:
Ref T12616. When you "Delete" a comment from the preview, we try to delete the comment on screen too.

It may or may not be present on screen: if you just added it it's usually visible. However, you might also have hidden the file it contains or it could be on an older diff in a file which is no longer present in the current diff.

After updates in T12616, we could only find the comment if you'd previously interacted with it for some reason. Update this code to be able to find all inlines present in the document.

Test Plan:

  • Write a draft comment.
  • Reload the page.
  • DO NOT INTERACT WITH THE COMMENT!
  • Delete it from the preview.
  • After patch: Comment is deleted from the document, too.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616

Differential Revision: https://secure.phabricator.com/D17937

Details

Provenance
epriestleyAuthored on May 17 2017, 6:39 PM
epriestleyPushed on May 17 2017, 7:26 PM
Reviewer
chad
Differential Revision
D17937: Allow any inline in the document to be queried by ID
Parents
rP75fb1a0327cb: Don't render an action list without actions
Branches
Unknown
Tags
Unknown
Tasks
T12616: Modernize display code for inline comments
Build Status
Buildable 17065
Build 22820: Run Core Tests