Page MenuHomePhabricator

Allow any inline in the document to be queried by ID
ClosedPublic

Authored by epriestley on May 17 2017, 6:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 6, 5:20 AM
Unknown Object (File)
Wed, Aug 3, 11:00 PM
Unknown Object (File)
Mon, Aug 1, 8:28 PM
Unknown Object (File)
Sat, Jul 30, 1:31 PM
Unknown Object (File)
Tue, Jul 26, 11:14 PM
Unknown Object (File)
Thu, Jul 14, 9:50 AM
Unknown Object (File)
Jun 27 2022, 10:58 PM
Unknown Object (File)
Jun 27 2022, 5:07 AM
Subscribers
None

Details

Summary

Ref T12616. When you "Delete" a comment from the preview, we try to delete the comment on screen too.

It may or may not be present on screen: if you just added it it's usually visible. However, you might also have hidden the file it contains or it could be on an older diff in a file which is no longer present in the current diff.

After updates in T12616, we could only find the comment if you'd previously interacted with it for some reason. Update this code to be able to find all inlines present in the document.

Test Plan
  • Write a draft comment.
  • Reload the page.
  • DO NOT INTERACT WITH THE COMMENT!
  • Delete it from the preview.
  • After patch: Comment is deleted from the document, too.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.May 17 2017, 7:26 PM
This revision was automatically updated to reflect the committed changes.