HomePhabricator

Fail gracefully on bad API call when building commit mail

This commit no longer exists in the repository. It may have been part of a branch which was deleted.

Description

Fail gracefully on bad API call when building commit mail

Summary:
Ref T8574. This could fail because the target is disabled (as here), or doesn't have access to the API, or the API request needs to be satisfied by a different host which isn't available.

In any of these cases, just show the failure and continue generating the mail. This field isn't important enough to block the mail, and many of these errors are permanent.

(I'll follow up on T8574 with some more permanent ideas to address this class of issue.)

Test Plan: Faked API call failure, generated mail, saw clean generation of mail with a failure message.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8574

Differential Revision: https://secure.phabricator.com/D13319

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Jun 16 2015, 11:37 PM
Reviewer
btrahan
Differential Revision
D13319: Fail gracefully on bad API call when building commit mail
Tasks
T8574: Users receiving many duplicate emails

Commit No Longer Exists

This commit no longer exists in the repository.